Nir Soffer has posted comments on this change. Change subject: storage: Introduce guarded utilities ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/61435/7/tests/storage_guarded_test.py File tests/storage_guarded_test.py: Line 236: @expandPermutations Line 237: class VolumeLeaseTest(VdsmTestCase): Line 238: Line 239: def setUp(self): Line 240: self.sanlock = FakeSanlock() We don't need this for testing VolumeLease, it is simpler to use a fake domain object and test that we called acquire and release on the domain. Line 241: Line 242: @contextmanager Line 243: def get_env(self, storage_type): Line 244: with fake_env(storage_type) as env: -- To view, visit https://gerrit.ovirt.org/61435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
