Nir Soffer has posted comments on this change. Change subject: storage: Introduce guarded utilities ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/61435/6/lib/vdsm/storage/guarded.py File lib/vdsm/storage/guarded.py: Line 135: def __hash__(self): Line 136: return hash(self._key()) Line 137: Line 138: def _key(self): Line 139: return type(self), self.ns, self.name, self.mode > But by definition, locks should be fully described by their type, ns, name, OK, lets continue with this. If we implement in the normal way as I suggested we may have locks that are not equal, but use the same ns, name and mode, so we will fail to acquire them. Line 140: Line 141: Line 142: class ResourceManagerLock(LockInterface): Line 143: def __init__(self, ns, name, mode): -- To view, visit https://gerrit.ovirt.org/61435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
