Yaniv Bronhaim has posted comments on this change. Change subject: infra tests: added functional test for upgrading vdsm ......................................................................
Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/61186/8/tests/functional/upgrade_vdsm_test.py File tests/functional/upgrade_vdsm_test.py: Line 45: Line 46: def tearDown(self): Line 47: service_start('vdsmd') Line 48: Line 49: def upgrade_test(self): Do a test also that verifies that if vdsmd was down, after upgrade it's still down. Line 50: try: Line 51: vdsm_version = run_command(['rpm', '-q', 'vdsm']) Line 52: run_command(['dnf', 'config-manager', '--add-repo', _url]) Line 53: run_command(['dnf', '--allowerasing', 'install', '--nogpgcheck', Line 58: except Exception: Line 59: raise Line 60: Line 61: self.assertEqual(run_command(['rpm', '-q', 'vdsm']), vdsm_version) Line 62: self.assertEqual(service_status('vdsmd'), 0) shouldn't it be assertNotEqual? -- To view, visit https://gerrit.ovirt.org/61186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
