Yaniv Bronhaim has posted comments on this change. Change subject: infra tests: added functional test for upgrading vdsm ......................................................................
Patch Set 8: (4 comments) https://gerrit.ovirt.org/#/c/61186/8/tests/functional/upgrade_vdsm_test.py File tests/functional/upgrade_vdsm_test.py: Line 38: try: Line 39: run_command( Line 40: ['dnf', 'config-manager', '--set-disabled', 'localsync']) Line 41: except Exception: Line 42: raise so why do you need to catch that? let it raise Line 43: Line 44: service_start('vdsmd') Line 45: Line 46: def tearDown(self): Line 43: Line 44: service_start('vdsmd') Line 45: Line 46: def tearDown(self): Line 47: service_start('vdsmd') why? if it didn't start after the upgrade, it won't start on tearDown Line 48: Line 49: def upgrade_test(self): Line 50: try: Line 51: vdsm_version = run_command(['rpm', '-q', 'vdsm']) Line 48: Line 49: def upgrade_test(self): Line 50: try: Line 51: vdsm_version = run_command(['rpm', '-q', 'vdsm']) Line 52: run_command(['dnf', 'config-manager', '--add-repo', _url]) _url should be named fc22_repo_url to be more clear, and have the same for other repos. or maybe it should be repo_url='http://resources.ovirt.org/pub/ovirt-3.6/rpm/%s/' Line 53: run_command(['dnf', '--allowerasing', 'install', '--nogpgcheck', Line 54: '-y', 'vdsm-4.17.10.1-0.fc22.noarch']) Line 55: run_command( Line 56: ['dnf', 'config-manager', '--set-enabled', 'localsync']) Line 55: run_command( Line 56: ['dnf', 'config-manager', '--set-enabled', 'localsync']) Line 57: run_command(['dnf', 'update', '-y', 'vdsm']) Line 58: except Exception: Line 59: raise same? Line 60: Line 61: self.assertEqual(run_command(['rpm', '-q', 'vdsm']), vdsm_version) -- To view, visit https://gerrit.ovirt.org/61186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
