Yaniv Bronhaim has posted comments on this change. Change subject: Adding units to memory metrics name according to metrics2.0 spec ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/62155/3//COMMIT_MSG Commit Message: Line 6: Line 7: Adding units to memory metrics name according to metrics2.0 spec Line 8: Line 9: According http://metrics20.org/spec/ this patch adds unit prefix for memory Line 10: values > M is actually wrong, (10^6), while we report MiB (1024^2). the meaning is the same. Line 11: Line 12: Change-Id: I1020b89c5ebb2412750352d6c2131097dcbaf407 Line 6: Line 7: Adding units to memory metrics name according to metrics2.0 spec Line 8: Line 9: According http://metrics20.org/spec/ this patch adds unit prefix for memory Line 10: values > Looking in this url, I don't see any requirement to add units to the keys. its the project's requirement. the spec defines the syntax and we use it as a reference. I'll document it instead of putting the link and use the units as constants . I'll change to M, probably a mistake and odd that I missed that Line 11: Line 12: Change-Id: I1020b89c5ebb2412750352d6c2131097dcbaf407 -- To view, visit https://gerrit.ovirt.org/62155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1020b89c5ebb2412750352d6c2131097dcbaf407 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
