Yaniv Bronhaim has posted comments on this change. Change subject: Adding units to memory metrics name according to metrics2.0 spec ......................................................................
Patch Set 4: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/62155/4/lib/vdsm/host/api.py File lib/vdsm/host/api.py: PS4, Line 124: elapsed_time > unit here as well? not related to that patch https://gerrit.ovirt.org/#/c/62155/4/lib/vdsm/metrics/__init__.py File lib/vdsm/metrics/__init__.py: Line 23: import importlib Line 24: from ..config import config Line 25: Line 26: # METRIC UNIT SUFFIX REPRESENTATION Line 27: MB = '_M' > hmm looking at the link from commit message I see: oh. you're absolutely right Line 28: Line 29: _reporter = None Line 30: Line 31: -- To view, visit https://gerrit.ovirt.org/62155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1020b89c5ebb2412750352d6c2131097dcbaf407 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
