Dan Kenigsberg has posted comments on this change.
Change subject: Using %{?_smp_mflags} in %install
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/62163/1/vdsm.spec.in
File vdsm.spec.in:
Line 743
Line 744
Line 745
Line 746
Line 747
> maybe.. why?
because the same reasoning that convinced Fedora to require it in %install
should apply here as well
Line 757:
Line 758: sed -i -e 's\@VDSMRPCPYLIBDIR@\%{python_sitelib}/%{vdsm_name}/rpc\g'
lib/vdsm/constants.py
Line 759:
Line 760: %install
Line 761: make %{?_smp_mflags} DESTDIR=%{buildroot} install
> in the re-review of vdsm package they asked to add it here because rpmlint
quieting a Fedora reviewer is a valid reason to add this flag, but let us make
it apparent in the commit message.
Line 762:
Line 763: # Creating VDSM logs in this session to avoid rpmbuild
Line 764: # complain during the build
Line 765: install -dDm 0755 %{buildroot}@VDSMLOGDIR@
--
To view, visit https://gerrit.ovirt.org/62163
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I290734e0ac4db6d6891428a9c149d631f5b705f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
