Nir Soffer has posted comments on this change.
Change subject: Using %{?_smp_mflags} in %install
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/62163/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-08-09 19:06:51 +0300
Line 6:
Line 7: Using %{?_smp_mflags} in %install
Line 8:
Line 9: To accelerate the build process
> no. -j just uses multi core processing
Does it make any difference for vdsm?
Line 10:
Line 11: Change-Id: I290734e0ac4db6d6891428a9c149d631f5b705f8
https://gerrit.ovirt.org/#/c/62163/1/vdsm.spec.in
File vdsm.spec.in:
Line 757:
Line 758: sed -i -e 's\@VDSMRPCPYLIBDIR@\%{python_sitelib}/%{vdsm_name}/rpc\g'
lib/vdsm/constants.py
Line 759:
Line 760: %install
Line 761: make %{?_smp_mflags} DESTDIR=%{buildroot} install
> quieting a Fedora reviewer is a valid reason to add this flag, but let us m
We should add this flag *only* if it improves the build or the installation
significantly.
Last time we blindly added code based on rpmlint vdsm was broken :-)
Line 762:
Line 763: # Creating VDSM logs in this session to avoid rpmbuild
Line 764: # complain during the build
Line 765: install -dDm 0755 %{buildroot}@VDSMLOGDIR@
--
To view, visit https://gerrit.ovirt.org/62163
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I290734e0ac4db6d6891428a9c149d631f5b705f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
