Yaniv Bronhaim has posted comments on this change. Change subject: Adding build-artifacts-manual.sh script ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/62560/2/automation/build-artifacts-manual.sh File automation/build-artifacts-manual.sh: PS2, Line 12: # autogen may already have been executed by check-patch.sh : if [ ! -f Makefile ]; then : ./autogen.sh --system --enable-hooks --enable-vhostmd : fi > do we ever need this in this script? better to have it. if currently we always run check-patch before we don't need it, but we might change the order -- To view, visit https://gerrit.ovirt.org/62560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaft...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
