Yaniv Bronhaim has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/62560/5/automation/build-artifacts-manual.sh
File automation/build-artifacts-manual.sh:

Line 13: 
Line 14: # autogen may already have been executed by check-patch.sh
Line 15: if [ ! -f Makefile ]; then
Line 16:     ./autogen.sh --system --enable-hooks --enable-vhostmd
Line 17: fi
you don't need this
Line 18: 
Line 19: # create the src.rpm, assuming the tarball is in the directory
Line 20: rpmbuild \
Line 21:     -D "_srcrpmdir $OUTPUT" \


Line 19: # create the src.rpm, assuming the tarball is in the directory
Line 20: rpmbuild \
Line 21:     -D "_srcrpmdir $OUTPUT" \
Line 22:     -D "_topmdir $BUILDS" \
Line 23:     -ts ./*.gz
be more specific - vdsm-*.tar.gz

but what if you have more than one tar in the folder? does it work?
Line 24: 
Line 25: # install any build requirements
Line 26: yum-builddep output/*src.rpm
Line 27: 


-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaft...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly <snaft...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to