Hello Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62941
to review the following change.
Change subject: certificates: remove config.read call
......................................................................
certificates: remove config.read call
config.read(file) loads a new configuration to 'config' based on the
file it reads. This call causes a bug and incosistency of vdsm
configuration since it overrides the right configuration.
config should be built from files in pre configured paths (drop-in
dirs) with priority determined by configuration file names.
Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1368115
Signed-off-by: Irit Goihman <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/62885
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
---
M lib/vdsm/tool/configurators/certificates.py
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/62941/1
diff --git a/lib/vdsm/tool/configurators/certificates.py
b/lib/vdsm/tool/configurators/certificates.py
index e5b373a..bfdf75a 100644
--- a/lib/vdsm/tool/configurators/certificates.py
+++ b/lib/vdsm/tool/configurators/certificates.py
@@ -68,11 +68,5 @@
def _certsExist():
- config.read(
- os.path.join(
- SYSCONF_PATH,
- 'vdsm/vdsm.conf'
- )
- )
return not config.getboolean('vars', 'ssl') or\
os.path.isfile(CERT_FILE)
--
To view, visit https://gerrit.ovirt.org/62941
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]
