Yaniv Bronhaim has submitted this change and it was merged. Change subject: certificates: remove config.read call ......................................................................
certificates: remove config.read call config.read(file) loads a new configuration to 'config' based on the file it reads. This call causes a bug and incosistency of vdsm configuration since it overrides the right configuration. config should be built from files in pre configured paths (drop-in dirs) with priority determined by configuration file names. Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1368115 Signed-off-by: Irit Goihman <igoih...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/62885 Continuous-Integration: Jenkins CI Reviewed-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/62941 --- M lib/vdsm/tool/configurators/certificates.py 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, approved Jenkins CI: Passed CI tests Irit Goihman: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f7c092a81af2dbe44cb60ab86c4bf74570b4514 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org