Edward Haas has posted comments on this change. Change subject: net: dhclient kill - early exit if iface does not exists ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63087/1/lib/vdsm/network/ip/dhclient.py File lib/vdsm/network/ip/dhclient.py: Line 94: kill_and_rm_pid(pid, self.pidFile) Line 95: Line 96: Line 97: def kill(device_name, family=4): Line 98: if not iface.exists(device_name): > I have a big personal grudge against ignoring such errors in a lower-level I have not changed the logic of kill in this regard. If we are to change its logic, there may be implications with specific callers and I prefer not to touch it in this patch. We could try to do this in a following patch. Line 99: return Line 100: for pid, pid_file in _pid_lookup(device_name, family): Line 101: logging.info('Stopping dhclient -%s on %s', family, device_name) Line 102: kill_and_rm_pid(pid, pid_file) -- To view, visit https://gerrit.ovirt.org/63087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ba37ce248f1daeec8e79bd192261c1840417310 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
