Edward Haas has posted comments on this change.

Change subject: net: dhclient kill - early exit if iface does not exists
......................................................................


Patch Set 6:

Another unrelated test fails on Jenkins slaves.
This does not make sense at all.

17:17:03 ======================================================================
17:17:03 FAIL: test_ip_info (network.netinfo_test.TestNetinfo)
17:17:03 ----------------------------------------------------------------------
17:17:03 Traceback (most recent call last):
17:17:03   File 
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/testValidation.py",
 line 97, in wrapper
17:17:03     return f(*args, **kwargs)
17:17:03   File 
"/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/network/netinfo_test.py",
 line 344, in test_ip_info
17:17:03     [IPV6_ADDR_CIDR]))
17:17:03 AssertionError: Tuples differ: ('192.0.2.2', '255.255.255.0',... != 
('192.0.2.2', '255.255.255.0',...
17:17:03 
17:17:03 First differing element 2:
17:17:03 ['192.0.2.2/24', '198.51.100.9/24', '198.51.100.11/32']
17:17:03 ['192.0.2.2/24', '198.51.100.9/24', '198.51.100.11/32', '192.0.2.3/24']
17:17:03 
17:17:03   ('192.0.2.2',
17:17:03    '255.255.255.0',
17:17:03 -  ['192.0.2.2/24', '198.51.100.9/24', '198.51.100.11/32'],
17:17:03 +  ['192.0.2.2/24', '198.51.100.9/24', '198.51.100.11/32', 
'192.0.2.3/24'],
17:17:03 ?                                                        
++++++++++++++++
17:17:03 
17:17:03    ['2607:f0d0:1002:51::4/64'])
17:17:03 -------------------- >> begin captured logging << --------------------

-- 
To view, visit https://gerrit.ovirt.org/63087
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ba37ce248f1daeec8e79bd192261c1840417310
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to