Yaniv Bronhaim has posted comments on this change. Change subject: integrate zombie reaper in supervdsmServer ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) Comment about your workaround with the python's bug. It's not related to that patch. .................................................... File vdsm/supervdsmServer.py Line 376: Line 377: # Python bug of thread.join() will block signal Line 378: # http://bugs.python.org/issue1167930 Line 379: while servThread.isAlive(): Line 380: servThread.join(5) They say in http://bugs.python.org/issue1167930 that this way won't necessarily work because another bug. I prefer that you will put this change as part of another patch and we'll decide if it's important here to handle KeyboardInterruped exception or not.. I'm not sure if we care about this bug anyway, when will we want to use control+C to stop this thread? Line 381: finally: Line 382: if os.path.exists(address): Line 383: os.unlink(address) Line 384: raise -- To view, visit http://gerrit.ovirt.org/9315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idccc34d8761fb9997cda1184552c6c8f633afbf0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
