Royce Lv has posted comments on this change. Change subject: integrate zombie reaper in supervdsmServer ......................................................................
Patch Set 3: (1 inline comment) Yaniv, Thanks for your review:) .................................................... File vdsm/supervdsmServer.py Line 376: Line 377: # Python bug of thread.join() will block signal Line 378: # http://bugs.python.org/issue1167930 Line 379: while servThread.isAlive(): Line 380: servThread.join(5) Work around in this way is not because we care about SIGINT, and there is no way to ctl+C a backgroud process, what we care about is thread.join(http://bugs.python.org/issue1167930)will block SIGCHLD. You can have a test to see that zombie reaper can't receive SIGCHLD and can't reap zombies until thread.join() has returned--that is when supervdsmServer exit. Check the python source Lib/threading.py will help to understand this. Line 381: finally: Line 382: if os.path.exists(address): Line 383: os.unlink(address) Line 384: raise -- To view, visit http://gerrit.ovirt.org/9315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idccc34d8761fb9997cda1184552c6c8f633afbf0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
