Edward Haas has posted comments on this change. Change subject: tests: fix testGetBondingOptions ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/63424/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-09-06 16:15:53 +0200 Line 6: Line 7: tests: fix testGetBondingOptions Line 8: Line 9: Bonding options are reported only if they differ from defaults. I do not understand how it worked so far. If the mode was reported, how did the test pass so far? What has changed? Line 10: Bond 'mode' is exceptional, it is reported always. We are not Line 11: interested in this one as it may differ from machine to machine. Line 12: Line 13: With this path we introduce new helper method which hides 'mode' -- To view, visit https://gerrit.ovirt.org/63424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If60c2e4fadf470e2325eb6014a6ddf051499b3ee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
