Edward Haas has posted comments on this change. Change subject: tests: fix testGetBondingOptions ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Please merge it urgently, it breaks master unit tests. https://gerrit.ovirt.org/#/c/63424/2/tests/network/netinfo_test.py File tests/network/netinfo_test.py: Line 247: bonds.flush() Line 248: Line 249: try: # no error is anticipated but let's make sure we can clean up Line 250: self.assertEqual( Line 251: self._bond_opts_without_mode(bondName), {}, We are missing the opts themselves in the msg output. Line 252: 'This test fails when a new bonding option is added to ' Line 253: 'the kernel. Please run vdsm-tool dump-bonding-options` ' Line 254: 'and retest.') Line 255: -- To view, visit https://gerrit.ovirt.org/63424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If60c2e4fadf470e2325eb6014a6ddf051499b3ee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
