Petr Horáček has posted comments on this change. Change subject: net test: Clean lease files on setup-cleanup ......................................................................
Patch Set 8: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/63089/8/tests/network/netfunctestlib.py File tests/network/netfunctestlib.py: Line 430: Line 431: return status, msg Line 432: Line 433: def _cleanup_lease_files(self, NETSETUP, BONDSETUP): Line 434: # TODO: iproute2 configurator is using iface==network's toplevel device it is the same for ifcfg bridgeless networks, isn't it? Line 435: # which is NOT the network name incase of a bridgeless network. Line 436: # iproute2 is already broken and not in use, but we better cover it. Line 437: for iface in NETSETUP: Line 438: utils.rmFile(dhclient.LEASE_FILE.format('', iface)) -- To view, visit https://gerrit.ovirt.org/63089 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
