Edward Haas has posted comments on this change. Change subject: net test: Clean lease files on setup-cleanup ......................................................................
Patch Set 10: -Verified (1 comment) https://gerrit.ovirt.org/#/c/63089/9/tests/network/netfunctestlib.py File tests/network/netfunctestlib.py: Line 416: NETSETUP = {net: {'remove': True} Line 417: for net in self.setup_networks if net in networks_caps} Line 418: BONDSETUP = {bond: {'remove': True} Line 419: for bond in self.setup_bonds if bond in bonds_caps} Line 420: status, msg = self.vdsm_proxy.setupNetworks(NETSETUP, BONDSETUP, NOCHK) > That's my point. You cannot clean up all lease files from this setup like t That is true... It will only cleanup lease files for networks it actually removes itself. We cannot cleanup on each setupNetworks, not even for a remove request, as the test may not have been over yet (and we want to cleanup only at the test end). I guess the only way to fully cover all created lease files is one of the following solutions: (can you think of anything else?) A) Cean lease file based on the prefix (dummy, veth, test-network). B) Save the list of files before the test, and on test termination check against them, removing all added ones. Option A has the disadvantage of being dependent on naming convention, but we can enforce it in the setupNetworks wrapper. Line 421: Line 422: nics_used = [attr['nic'] Line 423: for attr in six.itervalues(self.setup_networks) Line 424: if 'nic' in attr] -- To view, visit https://gerrit.ovirt.org/63089 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
