Nir Soffer has posted comments on this change. Change subject: jobs: Allow run and abort only from valid states ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/63711/2/lib/vdsm/jobs.py File lib/vdsm/jobs.py: Line 126: return self.status in (STATUS.PENDING, STATUS.RUNNING) Line 127: Line 128: def abort(self): Line 129: if not self.active: Line 130: raise JobNotActive() > If _abort() failed in a previous attempt, we change the state to ABORTED, s This should not be a problem if we fixed state changing, see comment in previous patch. Line 131: self._status = STATUS.ABORTED Line 132: logging.info('Job %r aborting...', self._id) Line 133: self._abort() Line 134: if self.autodelete: -- To view, visit https://gerrit.ovirt.org/63711 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8bc1ab264c5786b43fb409c3fab8913337778bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
