Nir Soffer has posted comments on this change.

Change subject: jobs: Allow run and abort only from valid states
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/63711/3/lib/vdsm/define.py
File lib/vdsm/define.py:

Line 87:     'migNotInProgress': exception.MigrationNotInProgress().response(),
Line 88:     'migrateLimit': exception.MigrationLimitExceeded().response(),
Line 89:     'recovery': exception.RecoveryInProgress().response(),
Line 90:     'hostdevDetachErr': exception.HostdevDetachFailed().response(),
Line 91:     'JobNotActive': exception.JobNotActive().response(),
Why not near the other job errors?
Line 92: }
Line 93: 
Line 94: 
Line 95: doneCode = {'code': 0, 'message': 'Done'}


-- 
To view, visit https://gerrit.ovirt.org/63711
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8bc1ab264c5786b43fb409c3fab8913337778bf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to