Petr Horáček has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
......................................................................
Patch Set 26: Verified-1
(1 comment)
It's broken. bond editation is between OVS editation methods, but in fact, OVS
changes are applied by context manager and happen after bond editation. Because
of that we are not able to move NIC from network to bonding:
>>> c.setupNetworks({'test-network': {'nic': 'dummy_1', 'switch': 'ovs'}}, {},
>>> {'connectivityCheck': False})
{'status': {'message': 'Done', 'code': 0}}
>>> c.setupNetworks({'test-network': {'bonding': 'bond1', 'switch': 'ovs'}},
>>> {'bond1': {'nics': ['dummy_1'], 'switch': 'ovs'}}, {'connectivityCheck':
>>> False})
{'status': {'message': 'Unexpected exception', 'code': 16}}
IOError: [Errno 16] Device or resource busy
https://gerrit.ovirt.org/#/c/63119/20//COMMIT_MSG
Commit Message:
PS20, Line 14: kept
i think we should remove all ovs bond related code (although i'm sad about
that, so much work!)
--
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
