Martin Sivák has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 138 Line 139 Line 140 Line 141 Line 142 > and if you don't you'll never see it. so for what? you can just write it to The whole point is to allow interested developers or users (or automation) to see it without bothering users, who can do nothing to solve it anyway. Nir already pointed out that it is the same approach Python itself uses. -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org