Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: Do not modify warnings filter in a library ......................................................................
vdsm: Do not modify warnings filter in a library vdsm.vdscli was modifying warnings filter, taking control from the application importing it. With the old code, there is no way to disable the warnings - if the application sets a warnings filter, importing vdscli will override the application filter. This warnings is highly unwanted, causing user facing warnings each time you run a vdsClient or hosted-engine command. This patch removes the wrong filter, returning control to the application using vdscli. Since warnings are hidden by default, this removes the unwanted warnings from vdsClient and hosted-engine command line tools. Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Bug-Url: https://bugzilla.redhat.com/1377069 Signed-off-by: Nir Soffer <nsof...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/64100 Continuous-Integration: Jenkins CI Reviewed-by: Simone Tiraboschi <stira...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> Reviewed-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-by: Piotr Kliczewski <piotr.kliczew...@gmail.com> --- M lib/vdsm/vdscli.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified Simone Tiraboschi: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org