Sahina Bose has posted comments on this change. Change subject: virt: enable glusterfs access through libgfapi interface ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/44061/8/vdsm/storage/glusterVolume.py File vdsm/storage/glusterVolume.py: Line 76: for brick in volInfo[volname]['bricks']] Line 77: Line 78: return {'path': glusterPath, Line 79: 'protocol': 'gluster', Line 80: 'volfileServer': volfileServer, > Why do we need this? yes volfileserver is one of the address of bricks. However volfileserver could be the user preferred server to access the volume. Especially in case that user has setup virtual IP, they may provide that as the volfileserver. We can change to add volfileserver as the first element in hosts, as I see it is not used in prepareVolumePath - let me know if right approach -- To view, visit https://gerrit.ovirt.org/44061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
