Nir Soffer has posted comments on this change. Change subject: virt: enable glusterfs access through libgfapi interface ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/44061/8/vdsm/storage/glusterVolume.py File vdsm/storage/glusterVolume.py: Line 76: for brick in volInfo[volname]['bricks']] Line 77: Line 78: return {'path': glusterPath, Line 79: 'protocol': 'gluster', Line 80: 'volfileServer': volfileServer, > yes volfileserver is one of the address of bricks. However volfileserver co Yes, this sounds like a good solution. Drive has a "hosts" and "protocol" attributes, and creating xml for network drive must use only these properties. See tests/vmStorageTests.py test_network. If you think that the current support for network drives is not good enough for gluster, please suggest a way to add the missing info in a generic way that can work for any network drive. I think Drive.volumeInfo is not used for anything now, and it will be removed soon. -- To view, visit https://gerrit.ovirt.org/44061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
