Dan Kenigsberg has posted comments on this change. Change subject: libvirtvm: use <interface type='network'> ......................................................................
Patch Set 1: (1 inline comment) .................................................... File tests/libvirtvmTests.py Line 263: interfaceXML = """ Line 264: <interface type="network"> <address %s/> Line 265: <mac address="52:54:00:59:F5:3F"/> Line 266: <model type="virtio"/> Line 267: <source network="vdsm-ovirtmgmt"/> in this context, "ovirtmgmt" is just another name for a network, as well as "engine". Both are valid examples. It might have been nicer to have both examples the same, but in any case, this issue precedes my current change and unrelated to it. If you insist, I can send a follow-up patch, changing the docstring to match the test. Line 268: <filterref filter="no-mac-spoofing"/> Line 269: <boot order="1"/> Line 270: <driver name="vhost"/> Line 271: <tune> -- To view, visit http://gerrit.ovirt.org/9441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If173a6351b1033c3a1c821cbadd05a2cbdf3d76c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
