Mark Wu has posted comments on this change.
Change subject: libvirtvm: use <interface type='network'>
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Another minor suggestion,
It's better to update the exaplation of network in @VmInterfaceDevice
# @network: The name of the attached host bridge device
It could just represent the libvirt network, but not for any host bridge.
....................................................
File vdsm/libvirtvm.py
Line 2794:
Line 2795: network = None
Line 2796: source = x.getElementsByTagName('source')
Line 2797: if source:
Line 2798: network = source[0].getAttribute('bridge')
What's the purpose of this code? Make sure not to break across vdsm live
upgrade?
It's better to add a comment
Line 2799: if not network:
Line 2800: network = source[0].getAttribute('network')
Line 2801: network =
network[len(netinfo.LIBVIRT_NET_PREFIX):]
Line 2802:
--
To view, visit http://gerrit.ovirt.org/9441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If173a6351b1033c3a1c821cbadd05a2cbdf3d76c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
