Dan Kenigsberg has posted comments on this change. Change subject: Improve the validation of netmask and gateway ......................................................................
Patch Set 5: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/configNetwork.py Line 727: "Bad gateway: %r" % gateway) Line 728: Line 729: (gw, ip, mask) = [_dottedQuadToNum(addr) for addr in Line 730: (gateway, ipaddr, netmask)] Line 731: if ip & mask != gw & mask: I think that it is perfectly legal to have the gw sit on a different network. Line 732: raise ConfigNetworkError(ne.ERR_BAD_ADDR, Line 733: "Bad gateway: %r" % gateway) Line 734: Line 735: -- To view, visit http://gerrit.ovirt.org/7713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c0a39f3f681a9e587f9118246e42a29e18d604b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
