Mark Wu has posted comments on this change. Change subject: Improve the validation of netmask and gateway ......................................................................
Patch Set 5: (1 inline comment) .................................................... File vdsm/configNetwork.py Line 715: if not _validateIpAddress(netmask): Line 716: raise ConfigNetworkError(ne.ERR_BAD_ADDR, Line 717: "Bad netmask: %r" % netmask) Line 718: Line 719: num = _dottedQuadToNum(netmask) Cool! Thanks for teaching how to handle to handle binary in python. I will update it in next patch. Line 720: if num & (num - 1) != (num << 1) & 0xffffffff: Line 721: raise ConfigNetworkError(ne.ERR_BAD_ADDR, "Bad netmask: %r" % netmask) Line 722: Line 723: -- To view, visit http://gerrit.ovirt.org/7713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c0a39f3f681a9e587f9118246e42a29e18d604b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
