Doron Fediuck has posted comments on this change.

Change subject: cpu mode support for vdsm
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 733:             cpu.appendChild(m)
Line 734: 
Line 735:         if ('smpCoresPerSocket' in self.conf or
Line 736:             'smpThreadsPerCore' in self.conf):
Line 737:             topo = self.doc.createElement('topology')
Sure. I agree with the concept.
Line 738:             vcpus = int(self.conf.get('smp', '1'))
Line 739:             cores = int(self.conf.get('smpCoresPerSocket', '1'))
Line 740:             threads = int(self.conf.get('smpThreadsPerCore', '1'))
Line 741:             topo.setAttribute('sockets', str(vcpus / cores / threads))


--
To view, visit http://gerrit.ovirt.org/9507
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54fb440ef52255f0a7933b000b9b599c2d056021
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to