Royce Lv has posted comments on this change.
Change subject: cpu mode support for vdsm
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
I like the concept, just minor comments
....................................................
Commit Message
Line 7: cpu mode support for vdsm
Line 8:
Line 9: This patch adds special hostPassthrough and hostModel as cpuType values.
Line 10: If the cpuType is one of these values, the <model> tag will not be
Line 11: created for libvirt, instead, a mode attribute will be crated in the
"crated"-->"created":)
Line 12: <cpu> tag with value 'host-passthrough' or 'host-model'.
Line 13:
Line 14: Change-Id: I54fb440ef52255f0a7933b000b9b599c2d056021
....................................................
File vdsm/libvirtvm.py
Line 709: """
Line 710: Add guest CPU definition.
Line 711:
Line 712: <cpu match="exact">
Line 713: <model>qemu64</model>
Maybe we can update the example in comments to make it more clear?
Line 714: <topology sockets="S" cores="C" threads="T"/>
Line 715: <feature policy="require" name="sse2"/>
Line 716: <feature policy="disable" name="svm"/>
Line 717: </cpu>
Line 719:
Line 720: features = self.conf.get('cpuType', 'qemu64').split(',')
Line 721: model = features[0]
Line 722: cpu = self.doc.createElement('cpu')
Line 723: cpu.setAttribute('match', 'exact')
For 'host-model' mode:Neither match attribute nor any feature elements can be
used in this mode.Since 0.8.5 the match attribute can be omitted and will
default to exact. May be we can just omit this?
Line 724:
Line 725: #and now for something completely different
Line 726: if model == 'hostPassthrough':
Line 727: cpu.setAttribute('mode', 'host-passthrough')
--
To view, visit http://gerrit.ovirt.org/9507
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54fb440ef52255f0a7933b000b9b599c2d056021
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Royce Lv <lvro...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
