Martin Polednik has posted comments on this change. Change subject: network: supervdsm: configure container networks ......................................................................
Patch Set 51: (3 comments) Slight concern regarding setup_network not in the followup patch + should (imho) be reviewed by networking team. https://gerrit.ovirt.org/#/c/54998/51/lib/vdsm/containerslib.py File lib/vdsm/containerslib.py: PS51, Line 50: Repo = lambda **kwargs: object() This is clever. Not sure if not slightly too clever, clever nevertheless. :) PS51, Line 168: # TODO: what if the users install the vdsm-containers package later? : # how can we setup_networks, or inform the user this should be done? : # TODO: handle ipv6 : # TODO: extract subnet from ipaddr Are these meant as an evolution of this patch or something to be done in followup? PS51, Line 179: setup_network Doesn't exist in followup?! -- To view, visit https://gerrit.ovirt.org/54998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107 Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
