Petr Horáček has posted comments on this change. Change subject: network: supervdsm: configure container networks ......................................................................
Patch Set 51: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/54998/51/vdsm/API.py File vdsm/API.py: Line 1513: Line 1514: try: Line 1515: self._cif._netConfigDirty = True Line 1516: supervdsm.getProxy().setupNetworks(networks, bondings, options) Line 1517: containersconnection.setup_networks(networks) this breaks setupNetworks rollback. if this line raises exception, API.setupNetworks fails, but networks configured by previous line are left on the host (they should be rolled back to initial state). i think we should move it to vdsm.network.api under rollback trigger. if it is possible that this will break host connectivity, we must also do some refactoring. if container network setup is dependent on switch type (linux bridge/ovs bridge), then we should place it in vdsm.network.netswitch (that would allow us to setup docker networks before connectivity check). Line 1518: return {'status': doneCode} Line 1519: except ConfigNetworkError as e: Line 1520: self.log.error(e.message, exc_info=True) Line 1521: return {'status': {'code': e.errCode, 'message': e.message}} -- To view, visit https://gerrit.ovirt.org/54998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107 Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
