Dan Kenigsberg has posted comments on this change. Change subject: storage: iscsiadm parses IPv6 iSCSI addresses ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/65707/13/vdsm/storage/iscsiadm.py File vdsm/storage/iscsiadm.py: Line 241: res = [] Line 242: for line in out: Line 243: rest, iqn = line.split() Line 244: rest, tpgt = rest.split(",") Line 245: ip, port = hosttail_split(rest) yes, your current modification is tiny, but I still suggest to use this opportunity to add a test for this function, mocking the output of _runCmd. Line 246: res.append((ip, int(port), int(tpgt), iqn)) Line 247: Line 248: return res Line 249: -- To view, visit https://gerrit.ovirt.org/65707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e9fa8d8f5ac34753ad6d40625e64dfeee1a3c02 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dhol...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dominik Holler <dhol...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
