Edward Haas has posted comments on this change. Change subject: storage: iscsiadm parses IPv6 iSCSI addresses ......................................................................
Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/65707/14/tests/iscsiTests.py File tests/iscsiTests.py: Line 65: Line 66: def test_discoverydb_discover(self): Line 67: def _fakeRunCmd(*ignored): Line 68: rc = 0 Line 69: out = ['[2001:db8:ca2:2:1::79]:3260,1 iqn.2014-06.com.example:t1', > ykaul suggested a longer list from the rfc. any reason not to have it all? I do not think that IPv6 testing is relevant to iscsi. Testing the correct interpretation of IPv6 will better fit for the IPv6 parser and not for the module that uses it. Line 70: '192.168.122.81:3261,2 iqn.2016-08.com.example:t2'] Line 71: error = '' Line 72: return rc, out, error Line 73: -- To view, visit https://gerrit.ovirt.org/65707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e9fa8d8f5ac34753ad6d40625e64dfeee1a3c02 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dhol...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dominik Holler <dhol...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org