Federico Simoncelli has posted comments on this change. Change subject: sdcache: add refresh to connectStoragePool ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/storage/sp.py Line 1239: """ Line 1240: Refresh storage pool. Line 1241: 'msdUUID' - master storage domain UUID Line 1242: """ Line 1243: sdCache.invalidateStorage() Now I'm actually worried about this change. We're injecting a "random" delay (iscsi-rescan time) somewhere in any following domain call/property-evaluation. Having it in connectStoragePool is safe because we're not connected to the pool yet but here we might have tasks going on (and the domain monitors). Line 1244: sdCache.refresh() Line 1245: self.__rebuild(msdUUID=msdUUID, masterVersion=masterVersion) Line 1246: Line 1247: -- To view, visit http://gerrit.ovirt.org/9422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d3adcff7bb0e97be5c797cd720c6353920d9db0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
