Federico Simoncelli has posted comments on this change. Change subject: sdcache: add refresh to connectStoragePool ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/storage/sp.py Line 639: self.id = hostID Line 640: self.scsiKey = scsiKey Line 641: # Make sure SDCache doesn't have stale data (it can be in case of FC) Line 642: sdCache.invalidateStorage() Line 643: sdCache.refresh() At least for me this doesn't look like running in circles. You probably didn't notice that in 9275 refresh was substituted by invalidateStorage (rescan multipath). That would have been correct if it wasn't for a special case (when you start the spm on a different node where you created the pool). In such case you also need to clean up (refresh) the domain cache. That is why we now need both. I agree that this looks very similar to self.refresh(). If you want I can resend the patch calling self.refresh() here, I think it's cleaner. Line 644: # Rebuild whole Pool Line 645: self.__rebuild(msdUUID=msdUUID, masterVersion=masterVersion) Line 646: self.__createMailboxMonitor() Line 647: -- To view, visit http://gerrit.ovirt.org/9422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d3adcff7bb0e97be5c797cd720c6353920d9db0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
