Hunt Xu has posted comments on this change. Change subject: Allow to remove NIC if it not in use ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/configNetwork.py Line 1061: for nic in nics: Line 1062: if not nicOtherUsers(network, vlan, bonding, nic): Line 1063: ifdown(nic) Line 1064: configWriter.removeNic(nic) Line 1065: ifup(nic) As the nic is removed since it's not in use, why do we still have to bring it up? Line 1066: Line 1067: Line 1068: def delNetwork(network, vlan=None, bonding=None, nics=None, force=False, Line 1069: configWriter=None, implicitBonding=True, **options): -- To view, visit http://gerrit.ovirt.org/9508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8e5fce14fc38c3df9c0b12dc4077726436807e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Meni Yakove <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
