Dan Kenigsberg has posted comments on this change. Change subject: Allow to remove NIC if it not in use ......................................................................
Patch Set 3: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/configNetwork.py Line 1056: print "Nics:", _netinfo.nics.keys() Line 1057: print "Bondings:", _netinfo.bondings.keys() Line 1058: Line 1059: Line 1060: def _updateNics(network, vlan, bonding, nics, configWriter): _removeUnusedNics() would be a better-fitting name. Line 1061: for nic in nics: Line 1062: if not nicOtherUsers(network, vlan, bonding, nic): Line 1063: ifdown(nic) Line 1064: configWriter.removeNic(nic) Line 1134: configWriter._updateConfigValue(cf, 'BRIDGE', '', True) Line 1135: Line 1136: # Now we can restart changed interface Line 1137: ifdown(iface) Line 1138: ifup(iface) needed only if the ifcfg if "iface" has changed (the else branch of line 1122) Line 1139: Line 1140: # The (relatively) new setupNetwork verb allows to remove a network Line 1141: # defined on top of an bonding device without break the bond itself. Line 1142: if implicitBonding: -- To view, visit http://gerrit.ovirt.org/9508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8e5fce14fc38c3df9c0b12dc4077726436807e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Meni Yakove <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
