Adam Litke has posted comments on this change. Change subject: add check-local for Makefile.am of vdsm api ......................................................................
Patch Set 1: We definitely need this kind of check to ensure that the schema has the proper syntax. But I think we also want to start generating the API documentation as a part of the build process and installing it in the %doc dir. Please update the patch to do this part as well. Thanks! -- To view, visit http://gerrit.ovirt.org/9433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a07e291822dae9179d3e8a4a90d654a776f085c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <shao...@linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
