Zhou Zheng Sheng has posted comments on this change. Change subject: add a Makefile command to generate vdsm-api.html ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) As you mentioned, .html should depend on vdsmapi-schema.json process-schema.py . .................................................... File vdsm_api/Makefile.am Line 20: nodist_noinst_DATA = \ Line 21: vdsm-api.html \ Line 22: $(NULL) Line 23: Line 24: vdsm-api.html: Yes. It should depend on vdsmapi-schema.json process-schema.py. Please update. Line 25: @echo " Generate $@" Line 26: PYTHONDONTWRITEBYTECODE=1 $(PYTHON) $(srcdir)/process-schema.py \ Line 27: $(srcdir)/vdsmapi-schema.json $(srcdir)/vdsm-api.html Line 28: -- To view, visit http://gerrit.ovirt.org/9433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a07e291822dae9179d3e8a4a90d654a776f085c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
