From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: net test: Bonds need a slave to be considered operational up ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/69280/1/tests/network/nmnettestlib.py File tests/network/nmnettestlib.py: Line 98: raise Line 99: Line 100: Line 101: def _add_slave_to_bond(bond, slave): Line 102: command = [IP_BINARY.cmd, 'link', 'set', slave, 'down'] do you intentionally reimplement bits of ipwrapper.linkSet()? I prefer re-using that code (for one's, it checks the return value of the command line). Line 103: _exec_cmd(command) Line 104: command = [IP_BINARY.cmd, 'link', 'set', slave, 'master', bond] Line 105: _exec_cmd(command) Line 106: -- To view, visit https://gerrit.ovirt.org/69280 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4f89593ab02617ea768715fb5293e1b4b550808 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
