From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: net test: Bonds need a slave to be considered operational up ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/69280/2/tests/network/nmnettestlib.py File tests/network/nmnettestlib.py: PS2, Line 105: _exec_cmd(command) I'd prefer running ipwrapper.linkSet([slave, 'master', bond]) unless you totally hate it. Otherwise, you are still wrapping ip command line. -- To view, visit https://gerrit.ovirt.org/69280 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4f89593ab02617ea768715fb5293e1b4b550808 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
