ShaoHe Feng has posted comments on this change.
Change subject: [WIP] netwiring: [3/3] Add API definitions.
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 1540: return {'status':
Line 1541: {'code':
errCode['updateDevice']['status']['code'],
Line 1542: 'message': 'Missing net device'}}
Line 1543:
Line 1544: network = dev['network']
netDev?
Line 1545:
Line 1546: # Prepare the updateDevice xml
Line 1547: netelem = xml.dom.minidom.Element(params['type'])
Line 1548: netelem.setAttribute('type', 'bridge')
Line 1546: # Prepare the updateDevice xml
Line 1547: netelem = xml.dom.minidom.Element(params['type'])
Line 1548: netelem.setAttribute('type', 'bridge')
Line 1549: mac = xml.dom.minidom.Element('mac')
Line 1550: mac.setAttribute('address', dev['macAddr'])
netDev?
Line 1551: netelem.appendChild(mac)
Line 1552: model = xml.dom.minidom.Element('model')
Line 1553: model.setAttribute('type', dev['nicModel'])
Line 1554: netelem.appendChild(model)
Line 1549: mac = xml.dom.minidom.Element('mac')
Line 1550: mac.setAttribute('address', dev['macAddr'])
Line 1551: netelem.appendChild(mac)
Line 1552: model = xml.dom.minidom.Element('model')
Line 1553: model.setAttribute('type', dev['nicModel'])
netDev?
Line 1554: netelem.appendChild(model)
Line 1555:
Line 1556: if 'network' not in params:
Line 1557: # If no network is specified we take the vnic to the
dummy bridge
--
To view, visit http://gerrit.ovirt.org/9562
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9b4f49f80466a83e3e13f1042ac2a8866c6bcd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
