Mark Wu has posted comments on this change.
Change subject: [WIP] netwiring: [4/4] Add API definitions.
......................................................................
Patch Set 14: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 1563: netParam = params.get('network')
Line 1564: if netParam is None:
Line 1565: # If no network is specified we take the vnic to the
dummy bridge
Line 1566: # and set the link 'down' always.
Line 1567: source.setAttribute('bridge', DUMMY_BRIDGE)
How does client outside vdsm know if it's still connected to the bridge?
Setting the link down is not enough? qemu will drop the packet from tap
interface silently if the link is down.
Line 1568: link.setAttribute('state', 'down')
Line 1569: else:
Line 1570: # There is a network defined. Thus, we either just
modify the link
Line 1571: # status and/or move between network backends.
--
To view, visit http://gerrit.ovirt.org/9562
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9b4f49f80466a83e3e13f1042ac2a8866c6bcd
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
