From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: confmeta: Add confmeta module ...................................................................... Patch Set 10: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/70583/10//COMMIT_MSG Commit Message: Line 21: Example usage: Line 22: Line 23: >>> from vdsm.tool import confmeta Line 24: >>>> confmeta.read_metadata(path) Line 25: ConfigMetadata(revision=3, private=False) > This module handle lvm.conf, and should replace the code in multipath.conf. Yaniv and Mooli, I tend to agree with Nir: his new configurator intends only to mark configuration files as "ours" or "private". It is quite distinct from editing ini files. maybe the name "configfile" is too broad. For example, multipath.conf is also a configuration file, and it is justly not handled by the configfile configurator. Line 26: Line 27: This module will be used to manage lvmlocal.conf file, and later will Line 28: replace the system used to manage multiapth.conf. Line 29: -- To view, visit https://gerrit.ovirt.org/70583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbd590853ca0acc47acd7823daf39931cd617638 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
