From Dan Kenigsberg <[email protected]>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: confmeta: Add confmeta module
......................................................................
confmeta: Add confmeta module
This module handles configuration files managed by vdsm, using a
metadata comments header.
Example file:
# This file is managed by vdsm
# description...
#REVISION: 3
#PRIVATE: NO
file contents...
Example usage:
>>> from vdsm.tool import confmeta
>>>> confmeta.read_metadata(path)
ConfigMetadata(revision=3, private=False)
This module will be used to manage lvmlocal.conf file, and later will
replace the system used to manage multiapth.conf.
Change-Id: Icbd590853ca0acc47acd7823daf39931cd617638
Bug-Url: https://bugzilla.redhat.com/1374545
Signed-off-by: Nir Soffer <[email protected]>
---
M lib/vdsm/tool/Makefile.am
A lib/vdsm/tool/confmeta.py
M tests/Makefile.am
A tests/tool_confmeta_test.py
M vdsm.spec.in
5 files changed, 259 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Verified; Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Objections:
Yaniv Bronhaim: I would prefer that you didn't submit this
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/70583
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbd590853ca0acc47acd7823daf39931cd617638
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Mooli Tayer <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
_______________________________________________
vdsm-patches mailing list -- [email protected]
To unsubscribe send an email to [email protected]
