From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: stop using during migration ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/72766/1/lib/vdsm/virt/migration.py File lib/vdsm/virt/migration.py: PS1, Line 223: self, 'self' is not used here. there is no reason to suddenly transform this module-level function to a method. since the function is here to stay, I would reinroduce its tests, which we drop unintentionally in I8217ff608ca3f1844034c259a09d7723d3644ed1 (do note that some disagree with me, and say that private functions should not be tested) -- To view, visit https://gerrit.ovirt.org/72766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c0301a8e4cd020e8f59f665da718394603a875c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
